[TEST] add test for invalid OTEL_BLRP_SCHEDULE_DELAY env value#3811
Merged
lalitb merged 1 commit intoopen-telemetry:mainfrom Jan 16, 2026
Merged
Conversation
|
|
Member
|
LGTM. This covers the non-parseable string case. If the intent is to validate overall robustness of |
lalitb
approved these changes
Jan 16, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3811 +/- ##
==========================================
+ Coverage 89.94% 89.96% +0.02%
==========================================
Files 225 225
Lines 7167 7167
==========================================
+ Hits 6446 6447 +1
+ Misses 721 720 -1 🚀 New features to boost your workflow:
|
Contributor
Author
|
Thanks for the review! Agreed ,those are good additional cases to cover. I’ll follow up with a separate PR to extend coverage for other invalid values. |
marcalff
changed the title
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a unit test covering the behavior when OTEL_BLRP_SCHEDULE_DELAY
is set to an invalid value.
Invalid values are logged with a warning and the default schedule delay
(1000ms) is used. The new test documents and locks in this fallback behavior
to reduce the risk of future regressions.
Related to #3806 .